[webkit-reviews] review granted: [Bug 79537] [chromium] Ensure we use the correct time when notifying animation started : [Attachment 130643] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted vollick at chromium.org's request
for review:
Bug 79537: [chromium] Ensure we use the correct time when notifying animation
started
https://bugs.webkit.org/show_bug.cgi?id=79537

Attachment 130643: Patch
https://bugs.webkit.org/attachment.cgi?id=130643&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130643&action=review


R=me but you're gonna have to sort the ChangeLog before this can land.

I think it would be good to have at least some unit tests that pass different
values for monotonic / wall clock times through the system as a way to try to
flush out code that uses the wrong one somewhere.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

this won't fly - there's an SVN presubmit that will reject this on the server.
just list the tests that cover this behavior

> Source/WebCore/platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:296
> +	 double wallClockTime = WTF::currentTime();

fyi: you don't need the WTF::, <wtf/CurrentTime.h> pulls the function into the
global namespace with a using statement (which is the standard pattern for wtf/
stuff)