[webkit-reviews] review granted: [Bug 78929] Full Screen Refactor Part 5: Support Lion's Full Screen Spaces in Full Screen mode. : [Attachment 127849] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 78929: Full Screen Refactor Part 5: Support Lion's Full Screen Spaces in
Full Screen mode.
https://bugs.webkit.org/show_bug.cgi?id=78929

Attachment 127849: Patch
https://bugs.webkit.org/attachment.cgi?id=127849&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127849&action=review


> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:247
> +	   // Already in Lion full-screen mode.

No need to use the term "Lion full-screen mode" here - eventually this will be
the default mode and then "Lion" will just be confusing. I'd just call this
"full-screen mode".

> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:316
> +	   // Not in Lion full-screen mode.

Ditto.