[webkit-reviews] review denied: [Bug 80466] [Forms] The "output" element should have labels. : [Attachment 130752] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 80466: [Forms] The "output" element should have labels.
https://bugs.webkit.org/show_bug.cgi?id=80466

Attachment 130752: Patch 1
https://bugs.webkit.org/attachment.cgi?id=130752&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130752&action=review


> LayoutTests/fast/forms/output/output-labels.html:1
> +<script src="../../js/resources/js-test-pre.js"></script>

The test coverage is not good.
I recommend you add "output" cases to existing fast/forms/labels-* tests.

> LayoutTests/fast/forms/output/output-labels.html:7
> +function collect(xs)

What does "xs" stand for?
The name "collect" is not so descriptive.

> LayoutTests/fast/forms/output/output-labels.html:14
> +{
> +  var result = '';
> +  for (var i = 0; i < xs.length; i++) {
> +    result += xs[i].id;
> +  }
> +  return result;
> +}

Wrong indentation.