[webkit-reviews] review granted: [Bug 80564] Do not refer to resutlsButtonElement and cancelButtonElement to compute paddings of search popups : [Attachment 130757] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 80564: Do not refer to resutlsButtonElement and cancelButtonElement to
compute paddings of search popups
https://bugs.webkit.org/show_bug.cgi?id=80564

Attachment 130757: Patch
https://bugs.webkit.org/attachment.cgi?id=130757&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=130757&action=review


>>>>> Source/WebCore/ChangeLog:11
>>>>> +        No behavior change.
>>>> 
>>>> Isn't there any existing test that _can_ be affected by this change, if
the change were wrong? I wanted to see "Test: xxx.html (No change behavior)",
to confirm that the change is correct.
>>> 
>>> Unfortunately, none.  We can't check the appearance of search popup menus
because DRT can't capture them.
>> 
>> We could grab the shadow tree using internals.shadowRoot() and dump its
RenderTree using internals.elementRenderTreeAsText()
>> You can make a reference DOM tree and compare the render-tree of the shadow
tree and the referende DOM.
> 
> It is not related to this patch.
> This patch doesn't change any renderer metrics or any DOM values. 
RenderTextControlSingleLine::clientInsetRight() and clientInsetLeft() are
passed to platform-specific popup-menu implementation via
ChromeClient::createSearchPopupMenu(). DRT doesn't have a way to get these
values.

Ah, got it. It would be nice if we have a mock for ChromeClient. But it's a
different story...