[webkit-reviews] review granted: [Bug 79112] Refactor code feature analysis in the parser : [Attachment 130642] new patch to run the ews

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Andy Wingo <wingo at igalia.com>'s
request for review:
Bug 79112: Refactor code feature analysis in the parser
https://bugs.webkit.org/show_bug.cgi?id=79112

Attachment 130642: new patch to run the ews
https://bugs.webkit.org/attachment.cgi?id=130642&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=130642&action=review


r=me

> Source/JavaScriptCore/parser/Nodes.h:1416
> +	   void setScopeFlags(ScopeFlags scopeFlags) { m_scopeFlags |=
scopeFlags; }

A setter with this name would traditionally overwrite the pre-existing value.
I'd suggest "addScopeFlags" instead.