[webkit-reviews] review denied: [Bug 80519] [BlackBerry] Set ResourceRequest TargetType in WebPagePrivate::load() : [Attachment 130653] Updated patch to set correct target type for WebKit internal loads too.

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Lyon Chen <liachen at rim.com>'s request
for review:
Bug 80519: [BlackBerry] Set ResourceRequest TargetType in
WebPagePrivate::load()
https://bugs.webkit.org/show_bug.cgi?id=80519

Attachment 130653: Updated patch to set correct target type for WebKit internal
loads too.
https://bugs.webkit.org/attachment.cgi?id=130653&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130653&action=review


>> Source/WebCore/loader/FrameLoader.cpp:1223
>> +#if PLATFORM(BLACKBERRY)
>> +	Frame* loadframe = targetFrame ? targetFrame : frame();
>> +	if (loadframe->page()->mainFrame() == loadframe)
>> +	    request.setTargetType(ResourceRequest::TargetIsMainFrame);
>> +	else
>> +	    request.setTargetType(ResourceRequest::TargetIsSubframe);
>> +#endif
>> +
> 
> Is there any way we can set this somewhere other than FrameLoader, preferably
somewhere that doesn't require an #if PLATFORM()? chromium, e.g., does this in
its FrameLoaderClientImpl::dispatchWillSendRequest().

We don't want to have PLATFORM-specific ifdefs in FrameLoader.	 We have a few
of them, but they are mostly sadness.  The Chromium port uses TargetType.  How
does it avoid needing this code here?