[webkit-reviews] review granted: [Bug 80541] Implement getAttributeNode() in terms of ElementAttributeData instead of NamedNodeMap : [Attachment 130693] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 7 15:32:45 PST 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 80541: Implement getAttributeNode() in terms of ElementAttributeData
instead of NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=80541

Attachment 130693: Patch
https://bugs.webkit.org/attachment.cgi?id=130693&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130693&action=review


> Source/WebCore/dom/ElementAttributeData.h:159
> +    Attribute* a = getAttributeItem(name, shouldIgnoreAttributeCase);

Please don't use one-letter abbreviations like "a". Instead, spell-out
attribute.

> Source/WebCore/dom/ElementAttributeData.h:168
> +    Attribute* a = getAttributeItem(name);

Ditto.


More information about the webkit-reviews mailing list