[webkit-reviews] review denied: [Bug 80524] [Qt] [WK2] Webkit fails to link when compiled with force_static_libs_as_shared : [Attachment 130665] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Viatcheslav Ostapenko
<ostapenko.viatcheslav at nokia.com>'s request for review:
Bug 80524: [Qt] [WK2] Webkit fails to link when compiled with
force_static_libs_as_shared
https://bugs.webkit.org/show_bug.cgi?id=80524

Attachment 130665: Patch
https://bugs.webkit.org/attachment.cgi?id=130665&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130665&action=review


One second thought, this seems to make sense. The class is declared in
WTFThreadData.h, why not define it in the .cpp. But there's the Chromium build
issue :)

> Source/JavaScriptCore/wtf/WTFThreadData.cpp:70
> +namespace JSC {
> +
> +IdentifierTable::~IdentifierTable()
> +{
> +    HashSet<StringImpl*>::iterator end = m_table.end();
> +    for (HashSet<StringImpl*>::iterator iter = m_table.begin(); iter != end;
++iter)
> +	   (*iter)->setIsIdentifier(false);
> +}
> +
> +std::pair<HashSet<StringImpl*>::iterator, bool>
IdentifierTable::add(StringImpl* value)
> +{
> +    std::pair<HashSet<StringImpl*>::iterator, bool> result =
m_table.add(value);
> +    (*result.first)->setIsIdentifier(true);
> +    return result;
>  }

This should be surrounded by #if USE(JSC) to fix the Chromium build.