[webkit-reviews] review granted: [Bug 64172] [Qt] Avoid using setSelectionRange in ::inputMethodEvent as it does not work for contentEditable : [Attachment 100123] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 7 11:53:40 PST 2012


Simon Hausmann <hausmann at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 64172: [Qt] Avoid using setSelectionRange in ::inputMethodEvent as it does
not work for contentEditable
https://bugs.webkit.org/show_bug.cgi?id=64172

Attachment 100123: Patch
https://bugs.webkit.org/attachment.cgi?id=100123&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me, but I agree with Enrica. Although that could also be done in a separate
patch if you want. Please also make sure that the existing input method tests
still pass :)


More information about the webkit-reviews mailing list