[webkit-reviews] review granted: [Bug 80179] [Qt] Add support for vertical sliders in mobile theme : [Attachment 129939] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 7 11:45:31 PST 2012


Simon Hausmann <hausmann at webkit.org> has granted Pierre Rossi
<pierre.rossi at gmail.com>'s request for review:
Bug 80179: [Qt] Add support for vertical sliders in mobile theme
https://bugs.webkit.org/show_bug.cgi?id=80179

Attachment 129939: Patch
https://bugs.webkit.org/attachment.cgi?id=129939&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129939&action=review


> Source/WebCore/platform/qt/RenderThemeQtMobile.cpp:471
> +    const int horizontalBorder = (vertical ? rect.width() / 4 : 0);
> +    const int verticalBorder = (vertical ? 0 : rect.height() / 4);

I personally tend to leave out the extra pair of parentheses here.


More information about the webkit-reviews mailing list