[webkit-reviews] review denied: [Bug 79614] [JSC] Memory allocation failed by fastmalloc even if heap grows successfully : [Attachment 129131] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 7 11:42:03 PST 2012


Geoffrey Garen <ggaren at apple.com> has denied hojong.han at samsung.com's request
for review:
Bug 79614: [JSC] Memory allocation failed by fastmalloc even if heap grows
successfully
https://bugs.webkit.org/show_bug.cgi?id=79614

Attachment 129131: Patch
https://bugs.webkit.org/attachment.cgi?id=129131&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I don't think it's a good idea to duplicate this code. Instead, after calling
GrowHeap(), I think it would be better to call TCMalloc_PageHeap::New
recursively. This is guaranteed to terminate after one level of recursion.


More information about the webkit-reviews mailing list