[webkit-reviews] review granted: [Bug 79867] [BlackBerry] Upstream GraphicsLayerBlackBerry.{h, cpp} : [Attachment 130582] patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 7 11:30:11 PST 2012


Rob Buis <rwlbuis at gmail.com> has granted Robin Cao
<robin.cao at torchmobile.com.cn>'s request for review:
Bug 79867: [BlackBerry] Upstream GraphicsLayerBlackBerry.{h, cpp}
https://bugs.webkit.org/show_bug.cgi?id=79867

Attachment 130582: patch v3
https://bugs.webkit.org/attachment.cgi?id=130582&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=130582&action=review


Almost there, have a look especially at the release issue. Maybe you can get
Leo to cq+ for you once fixed.

> Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:146
> +    if (GraphicsLayer::replaceChild(oldChild, newChild)) {

I think early return may look better here.

> Source/WebCore/platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:384
> +	       return layerAnimation.release();

I dont think you want to release here? Note that removeAnimationByIdAndProperty
doesnt do it either.


More information about the webkit-reviews mailing list