[webkit-reviews] review granted: [Bug 80522] Implement removeAttributeNode() in terms of ElementAttributeData instead of NamedNodeMap : [Attachment 130651] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 80522: Implement removeAttributeNode() in terms of ElementAttributeData
instead of NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=80522

Attachment 130651: Patch
https://bugs.webkit.org/attachment.cgi?id=130651&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130651&action=review


r=me

> Source/WebCore/dom/Element.cpp:192
>      if (!m_attributeMap)
>	   return;
>  
> -    m_attributeMap->removeAttribute(name);
> +    m_attributeMap->attributeData()->removeAttribute(name, this);

You could bypass m_attributeMap entirely here and just use
Element::attributeData().