[webkit-reviews] review granted: [Bug 80370] Enable matched declaration caching for elements with a style attribute : [Attachment 130609] another qt build fix attempt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 7 10:52:22 PST 2012


Andreas Kling <kling at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 80370: Enable matched declaration caching for elements with a style
attribute
https://bugs.webkit.org/show_bug.cgi?id=80370

Attachment 130609: another qt build fix attempt
https://bugs.webkit.org/attachment.cgi?id=130609&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130609&action=review


This looks pretty cool. r=me, assuming the EWS failure is a flake.

> Source/WebCore/dom/ElementAttributeData.cpp:70
> +	   m_inlineStyleDecl = m_inlineStyleDecl->copy();
> +	   m_inlineStyleDecl->setStrictParsing(element->isHTMLElement() &&
!element->document()->inQuirksMode());

I feel like copy() should return a StylePropertySet with the same strictness
setting as the original.


More information about the webkit-reviews mailing list