[webkit-reviews] review denied: [Bug 78882] [CSSRegions][CSSOM] Implement regionLayoutEvent : [Attachment 130439] New patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 7 09:10:14 PST 2012


Dave Hyatt <hyatt at apple.com> has denied Raul Hudea <rhudea at adobe.com>'s request
for review:
Bug 78882: [CSSRegions][CSSOM] Implement regionLayoutEvent
https://bugs.webkit.org/show_bug.cgi?id=78882

Attachment 130439: New patch
https://bugs.webkit.org/attachment.cgi?id=130439&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=130439&action=review


> Source/WebCore/rendering/RenderFlowThread.cpp:349
> +static bool hasRegionLayoutUpdateListeners(Node* node)
> +{
> +    if (!node)
> +	   return false;
> +
> +    if (node->hasEventListeners(eventNames().webkitRegionLayoutUpdateEvent))

> +	   return true;
> +
> +    for (node = node->parentNode(); node; node = node->parentNode())
> +	   if
(node->hasEventListeners(eventNames().webkitRegionLayoutUpdateEvent))
> +	       return true;
> +
> +    return false;
> +}

I wasn't really asking for a node crawl all the way up... just for something a
bit simpler, e.g., a single global that indicated whether there are any
registered listeners anywhere in the document.


More information about the webkit-reviews mailing list