[webkit-reviews] review granted: [Bug 80495] [GTK] race condition in run-gtk-tests : [Attachment 130627] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 80495: [GTK] race condition in run-gtk-tests
https://bugs.webkit.org/show_bug.cgi?id=80495

Attachment 130627: Patch
https://bugs.webkit.org/attachment.cgi?id=130627&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130627&action=review


Looks good, but consider converting the a11y stuff to use with. Perhaps this
could be a follwoup patch.

> Tools/Scripts/run-gtk-tests:149
> +	   def run_for_real():

Maybe run_for_real could be called run_tests. :)

> Tools/Scripts/run-gtk-tests:164
> +	       if self._a11y_registryd:
> +		   self._a11y_registryd.terminate()
> +
> +	       a11y_bus_launcher.terminate()

It seems we want to be really sure that the a11y stuff is cleaned up properly
when exiting the loop, so I think it makes sense to use "with" here.
http://docs.python.org/release/2.5/whatsnew/pep-343.html Without using this, we
run the risk of an exception preventing the termination of the a11y stuff. I
think I've seen this happen to me.