[webkit-reviews] review requested: [Bug 76838] [chromium] Cull occluded tiles during paint : [Attachment 130623] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 7 07:33:50 PST 2012


Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 76838: [chromium] Cull occluded tiles during paint
https://bugs.webkit.org/show_bug.cgi?id=76838

Attachment 130623: Patch
https://bugs.webkit.org/attachment.cgi?id=130623&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
- Paint-cull tiles if their dirty rect is occluded (instead of if their whole
tile bounds are occluded).
- Added unit test coverage for this.
- Removed the TRACE_EVENT.

I'd like to do the TRACE stuff in a separate CL. Thanks @enne for pointing out
@wjmaclean's histogram stuff in CCQuadCuller now. I need to add some support
for this with CCOcclusionTracker, and I'd like to cover the paint culling at
the same time.

Also, I'd like to push the data in his histograms into TRACE_COUNTER's as well
for debugging, probably.


More information about the webkit-reviews mailing list