[webkit-reviews] review granted: [Bug 80500] [GTK] remove webkitpy dependency in run-gtk-tests : [Attachment 130570] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 80500: [GTK] remove webkitpy dependency in run-gtk-tests
https://bugs.webkit.org/show_bug.cgi?id=80500

Attachment 130570: Patch
https://bugs.webkit.org/attachment.cgi?id=130570&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130570&action=review


Great! Thank you!

> Tools/Scripts/run-gtk-tests:154
> -		   out = self._executive.run_command([jhbuild_path ,'gtester',
test], env=test_env,
> -						    
error_handler=_error_handler)
> +		   process = subprocess.Popen([jhbuild_path ,'gtester', test],
env=test_env, stdout=subprocess.PIPE)
> +		   out = process.communicate()[0]
>		   sys.stdout.write(out)

If you omit the stdout argument altogether, I believe the default is to route
it to stdout anyway. Perhaps you can just omit that and sys.stdout.write(out)
sys.stdout.flush() altogether.