[webkit-reviews] review denied: [Bug 80145] FileInputType doesn't support (save|restore)FormControlState : [Attachment 130580] .

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Marja Hölttä <marja at chromium.org>'s
request for review:
Bug 80145: FileInputType doesn't support (save|restore)FormControlState
https://bugs.webkit.org/show_bug.cgi?id=80145

Attachment 130580: .
https://bugs.webkit.org/attachment.cgi?id=130580&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130580&action=review


> Source/WebCore/html/FileInputType.cpp:119
> +    element()->setFiles(files);

HTMLInputElement::setFiles() is unnecessary.  filesChosen() can be called here.


>
LayoutTests/http/tests/local/formdata/recover-file-input-in-unposted-form.html:
52
> +	   var xhr = new XMLHttpRequest();
> +	   xhr.open("POST",
"http://127.0.0.1:8000/xmlhttprequest/resources/multipart-post-echo.php",
false);
> +	   xhr.send(new FormData(document.getElementById("form")));
> +	   var expectedResponse = "posted-text=text to be
posted&posted-file=test.txt:text/plain:Hello";
> +	   if (xhr.responseText = expectedResponse)

Why do you need to submit the form? Checking the value of file-input isn't
enough?