[webkit-reviews] review denied: [Bug 80503] [Qt] Fix compilation without QtQuick1 : [Attachment 130566] Patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has denied Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 80503: [Qt] Fix compilation without QtQuick1
https://bugs.webkit.org/show_bug.cgi?id=80503

Attachment 130566: Patch
https://bugs.webkit.org/attachment.cgi?id=130566&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130566&action=review


> Source/WebKit/qt/declarative/public.pri:37
> +haveQt(4)|!isEmpty(QT.quick1.name) {
> +    haveQt(5): QT += quick1
> +    DEFINES += HAVE_QQUICK1
> +    SOURCES += qdeclarativewebview.cpp
> +    HEADERS += qdeclarativewebview_p.h
> +}

The detection part of this should be in features.prf, and this part should do
contains(DEFINES, HAVE_QQUICK1=1) {}

> Source/tests.pri:30
> +!isEmpty(QT.quick1.name)|haveQt(4) {
> +    contains(QT_CONFIG, declarative): SUBDIRS +=
$$WEBKIT_TESTS_DIR/qdeclarativewebview

That way you can reuse the detection from features.prf here