[webkit-reviews] review requested: [Bug 80474] Web Inspector: Cannot insert right curly bracket on some keyboards : [Attachment 130523] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has asked  for review:
Bug 80474: Web Inspector: Cannot insert right curly bracket on some keyboards
https://bugs.webkit.org/show_bug.cgi?id=80474

Attachment 130523: Patch
https://bugs.webkit.org/attachment.cgi?id=130523&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130523&action=review


> Source/WebCore/inspector/front-end/inspector.js:720
> +    var hasCtrlOrMeta =
WebInspector.KeyboardShortcut.eventHasCtrlOrMeta(event) && !event.shiftKey &&
!event.altKey;

I would rename the variable into something like "hasOnlyCtrlOrMeta" in order to
differentiate it from the "normal" hasCtrlOrMeta checks around the code.
Otherwise looks good; thanks for diagnosing and fixing this.