[webkit-reviews] review denied: [Bug 80005] Implement strict testing criterion for callback function definition : [Attachment 130559] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 7 00:51:16 PST 2012


Kentaro Hara <haraken at chromium.org> has denied Yanbin
<yanbin.zhang at intel.com>'s request for review:
Bug 80005: Implement strict testing criterion for callback function definition
https://bugs.webkit.org/show_bug.cgi?id=80005

Attachment 130559: patch
https://bugs.webkit.org/attachment.cgi?id=130559&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
Sorry for the iterative comments.

(1) You need to update the test result, i.e.
fast/mediastream/peerconnection-argument-types-expected.txt. In this case, the
result of chromium would be different from the result of other platforms. So
you can add the result of chromium to
platform/chromium/fast/mediastream/peerconnection-argument-types-expected.txt,
and update the result of other platforms in
fast/mediastream/peerconnection-argument-types-expected.txt.

(2) Would you please file a bug of JSValue? It would be a good idea to add a
comment "// FAIL in JavaScriptCore due to http://<link to the bug>" on the
'test('new webkitPeerConnection("TURNS NONE",{})', true);' line.


More information about the webkit-reviews mailing list