[webkit-reviews] review denied: [Bug 80005] Implement strict testing criterion for callback function definition : [Attachment 130557] updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 7 00:10:43 PST 2012
Kentaro Hara <haraken at chromium.org> has denied Yanbin
<yanbin.zhang at intel.com>'s request for review:
Bug 80005: Implement strict testing criterion for callback function definition
https://bugs.webkit.org/show_bug.cgi?id=80005
Attachment 130557: updated patch
https://bugs.webkit.org/attachment.cgi?id=130557&action=review
------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130557&action=review
> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1233
> + push(@andExpression, "(${value}.isNull() ||
${value}.isFunction())");
Sorry. There is no method JSValue.isFunction():
http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/Jav
aScriptCore/runtime/JSValue.h&exact_package=chromium&q=jsvalue&type=cs
Is there any alternative in JavaScriptCore?
More information about the webkit-reviews
mailing list