[webkit-reviews] review granted: [Bug 80005] Implement strict testing criterion for callback function definition : [Attachment 130557] updated patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Yanbin
<yanbin.zhang at intel.com>'s request for review:
Bug 80005: Implement strict testing criterion for callback function definition
https://bugs.webkit.org/show_bug.cgi?id=80005

Attachment 130557: updated patch
https://bugs.webkit.org/attachment.cgi?id=130557&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130557&action=review


Looks OK.

>> Aren't there any tests that are affected by this change?
>--- I only find this test case now. And i have run test cases via
"new-run-webkit-tests chromium ". no other test cases was found.

What's "chromium "? Anyway, the commit queue will tell you if there are any
failing tests. If you want to commit it, please change "cq:" to "cq:?".

> Source/WebCore/ChangeLog:7
> +

You can write the comment "Implement strict testing criterion for callback
function definition.Callback function should be defined as Function strictly
instead of Object. While, IsFunction is inherited from IsObject .Existing code
only check callback function should be an object. This patch is implement
strict testing criterion for callback function definition." here. Also it might
be a good idea to add a link to the Web IDL spec that supports this change.