[webkit-reviews] review requested: [Bug 80005] Implement strict testing criterion for callback function definition : [Attachment 130557] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 6 23:51:55 PST 2012


Yanbin <yanbin.zhang at intel.com> has asked  for review:
Bug 80005: Implement strict testing criterion for callback function definition
https://bugs.webkit.org/show_bug.cgi?id=80005

Attachment 130557: updated patch
https://bugs.webkit.org/attachment.cgi?id=130557&action=review

------- Additional Comments from Yanbin <yanbin.zhang at intel.com>
Implement strict testing criterion for callback function definition.Callback
function should be defined as Function strictly instead of Object. While,
IsFunction is inherited from IsObject .Existing code only check callback
function should be an object. This patch is implement strict testing criterion
for callback function definition.

corresponding test cases has been modified.
fast/mediastream/script-tests/argument-types.js



> LayoutTests/ChangeLog:8
> +	   * fast/mediastream/script-tests/argument-types.js:

Aren't there any tests that are affected by this change?
--- I only find this test case now. And i have run test cases via
"new-run-webkit-tests chromium ". no other test cases was found.


More information about the webkit-reviews mailing list