[webkit-reviews] review granted: [Bug 80137] [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled : [Attachment 130314] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 6 23:36:58 PST 2012
Eric Seidel <eric at webkit.org> has granted Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 80137: [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled
https://bugs.webkit.org/show_bug.cgi?id=80137
Attachment 130314: proposed patch
https://bugs.webkit.org/attachment.cgi?id=130314&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130314&action=review
LGTM.
> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:439
> +void LayoutTestController::setPopupBlockingEnabled(bool flag)
Woudl be better to use a nicer name. Like enablePopupBlocking.
More information about the webkit-reviews
mailing list