[webkit-reviews] review denied: [Bug 79104] Unaligned userspace access for SH4 platforms : [Attachment 127968] fix unaligend access memory issue in YARR JIT

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied thouraya <thouraya.andolsi at st.com>'s
request for review:
Bug 79104: Unaligned userspace access for SH4 platforms
https://bugs.webkit.org/show_bug.cgi?id=79104

Attachment 127968: fix unaligend access memory issue in YARR JIT
https://bugs.webkit.org/attachment.cgi?id=127968&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=127968&action=review


> Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:978
> +	   m_assembler.ensureSpace(m_assembler.maxInstructionSize + 68,
sizeof(uint32_t));
> +	   move(scr, SH4Registers::r0);
> +	   m_assembler.andlImm8r(0x3, SH4Registers::r0);
> +	   m_assembler.cmpEqImmR0(0x0, SH4Registers::r0);
> +	   m_assembler.branch(BF_OPCODE, 2 + extraInst);
> +
> +	   if (dest != SH4Registers::r0)
> +	       move(scr1, SH4Registers::r0);
> +
> +	   load32(scr, dest);
> +	   m_assembler.branch(BRA_OPCODE, 25 + extraInst);
> +	   m_assembler.nop();
> +
> +	   m_assembler.andlImm8r(0x1, SH4Registers::r0);
> +	   m_assembler.cmpEqImmR0(0x0, SH4Registers::r0);
> +
> +	   if (dest != SH4Registers::r0)
> +	       move(scr1, SH4Registers::r0);
> +
> +	   m_assembler.branch(BF_OPCODE, 8);

Why aren't you just using the macro assembler API instead of having to manually
compute branch offsets?