[webkit-reviews] review granted: [Bug 80425] [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture : [Attachment 130504] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 6 22:51:54 PST 2012


Simon Hausmann <hausmann at webkit.org> has granted Dinu Jacob
<dinu.jacob at Nokia.com>'s request for review:
Bug 80425: [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
https://bugs.webkit.org/show_bug.cgi?id=80425

Attachment 130504: Patch
https://bugs.webkit.org/attachment.cgi?id=130504&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130504&action=review


> Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:196
> +	   touchPoint.setStartScenePos(m_startScreenPos);

You're right, the double tap recognizer uses the start screen pos, but there's
a typo in this line where the start_screen_ pos is set on the start_Scene_ pos
property. Please fix before landing :)


More information about the webkit-reviews mailing list