[webkit-reviews] review denied: [Bug 80005] V8 javascript engine should throw an exception on this case : [Attachment 130508] patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Yanbin
<yanbin.zhang at intel.com>'s request for review:
Bug 80005: V8 javascript engine should throw an exception on this case
https://bugs.webkit.org/show_bug.cgi?id=80005

Attachment 130508: patch
https://bugs.webkit.org/attachment.cgi?id=130508&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130508&action=review


The change in CodeGeneratorV8.pm looks OK.

I think CodeGeneratorJS.pm has the same issue. Would you please fix it?
Otherwise, argument-types.html will fail in Mac.

> Source/WebCore/ChangeLog:3
> +	   V8 javascript engine should throw an exception on this case

More descriptive title please

> Source/WebCore/ChangeLog:7
> +

Please describe what your patch is doing.

> Source/WebCore/ChangeLog:8
> +	   No new tests. (OOPS!)

You can write "Test: fast/mediastream/argument-types.html"

> LayoutTests/ChangeLog:8
> +	   * fast/mediastream/script-tests/argument-types.js:

Aren't there any tests that are affected by this change?