[webkit-reviews] review requested: [Bug 79961] [chromium] Font fallback in cr-win is wrong for string contains zero-width-space : [Attachment 130486] patch w/ layout test

[bugzilla-daemon at webkit.org]

Xiaomei Ji <xji at chromium.org> has asked  for review:
Bug 79961: [chromium] Font fallback in cr-win is wrong for string contains
zero-width-space
https://bugs.webkit.org/show_bug.cgi?id=79961

Attachment 130486: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=130486&action=review

------- Additional Comments from Xiaomei Ji <xji at chromium.org>
Thanks for the review!

(In reply to comment #2)
> (From update of attachment 129728 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=129728&action=review
> 
> If possible, I'd rather add a layout test that does not rely on the actual
font used. Revising zero-width-characters-complex-script.html would be better,
wouldn't it?

Yes. Done.

> 
> > Source/WebCore/platform/graphics/chromium/UniscribeHelper.cpp:889
> > +		 bool treatAsZeroWidthSpace = c == zeroWidthSpace ||
Font::treatAsZeroWidthSpaceInComplexScript(c);
> 
> Can you add ZWSP to the set of characters returned by treatAsZeroWidth....?

Looks like it is save to add ZWSP as one of the characters to be
treatedAsZeroWidthSpaceInComplexSccipt. Done.