[webkit-reviews] review granted: [Bug 80051] Update usage of LayoutUnits in InlineBox and InlineFlowBox : [Attachment 130168] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 6 17:08:11 PST 2012
Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 80051: Update usage of LayoutUnits in InlineBox and InlineFlowBox
https://bugs.webkit.org/show_bug.cgi?id=80051
Attachment 130168: Patch
https://bugs.webkit.org/attachment.cgi?id=130168&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130168&action=review
Looks OK.
> Source/WebCore/ChangeLog:8
> + Updating LayoutUnit vs Integer usage in InlineBox and InlineFlowBox.
Please explain why. I guess you did some in the individual changes below...
You could even link to your fancy wiki. :) "Although the LineBox tree uses
floats internally, borders/padding are caulated with LayoutUnits, like the rest
of block layout in the rendering tree. See the wiki *URL* for more details."
More information about the webkit-reviews
mailing list