[webkit-reviews] review denied: [Bug 80027] [chromium] Increase size of Combo Box Options for touch and high DPI devices : [Attachment 129710] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Tim Dresser
<tdresser at chromium.org>'s request for review:
Bug 80027: [chromium] Increase size of Combo Box Options for touch and high DPI
devices
https://bugs.webkit.org/show_bug.cgi?id=80027

Attachment 129710: Patch
https://bugs.webkit.org/attachment.cgi?id=129710&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129710&action=review


> Source/WebCore/platform/chromium/PopupListBox.cpp:49
> +#include "Settings.h"

do you really need this include?

> Source/WebCore/platform/chromium/PopupListBox.cpp:357
> +    const int& scale = m_settings.defaultDeviceScaleFactor;

why make this a reference?  it seems like making a copy of the int should be
sufficient unless you really need the indirection.

> Source/WebCore/platform/chromium/PopupListBox.cpp:397
> +    const int& scale = m_settings.defaultDeviceScaleFactor;

ditto

> Source/WebCore/platform/chromium/PopupListBox.cpp:401
> +	   // Height and y will both be evenly divisible by scale.

should you perhaps assert this?  it seems like rounding errors if possible
would be annoying.

> Source/WebCore/platform/chromium/PopupListBox.cpp:632
> +    const int& scale = m_settings.defaultDeviceScaleFactor;

ditto

> Source/WebCore/platform/chromium/PopupListBox.cpp:634
> +    if (WebCore::RuntimeEnabledFeatures::touchEnabled())

you should not need the "WebCore::" prefix

> Source/WebCore/rendering/RenderMenuList.cpp:312
> +    const int& scale =
document()->page()->settings()->defaultDeviceScaleFactor();

no reference

> Source/WebKit/chromium/src/WebViewImpl.cpp:637
> +	   // That tap triggered a select popup which is the same as the one
that

so we will see a flickering of the select popup?  is there some way to mitigate
/ avoid that?