[webkit-reviews] review denied: [Bug 80430] [BlackBerry] Set correct ResourceRequest target type. : [Attachment 130406] Patch for 80430

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Lyon Chen <liachen at rim.com>'s request
for review:
Bug 80430: [BlackBerry] Set correct ResourceRequest target type.
https://bugs.webkit.org/show_bug.cgi?id=80430

Attachment 130406: Patch for 80430
https://bugs.webkit.org/attachment.cgi?id=130406&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=130406&action=review


The HashMap needs to be static for sure.

> Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:92
> +    MimeTypeResourceRequestTypeMap* map = 0;

You need to make it static, otherwise you keep allocating it each time the
function is called.

> Source/WebCore/platform/network/blackberry/ResourceRequestBlackBerry.cpp:114
> +	       // map->add(String(""), ResourceRequest::TargetIsMedia);

Maybe better not include the commented three lines.

> Source/WebKit/blackberry/ChangeLog:8
> +	   Removed unused code in dispatchWillSendRequest(), they are too late!


Can you explain what and why it is too late?