[webkit-reviews] review denied: [Bug 37835] getComputedStyle returns incorrect values for the width and height of pseudo-elements : [Attachment 130427] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Alexis Menard (darktears)
<alexis.menard at openbossa.org>'s request for review:
Bug 37835: getComputedStyle returns incorrect values for the width and height
of pseudo-elements
https://bugs.webkit.org/show_bug.cgi?id=37835

Attachment 130427: Patch
https://bugs.webkit.org/attachment.cgi?id=130427&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130427&action=review


We need more tests for this.  Changing the renderer pointer impacts more than
just width and height, we should test as many values as possible.

Also, you should add tests without display:block and with auto sizing.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1344
> +    if (m_pseudoElementSpecifier == AFTER)
> +	   renderer = renderer->afterPseudoElementRenderer();
> +
> +    if (m_pseudoElementSpecifier == BEFORE)

else if since we can't be both AFTER and BEFORE.