[webkit-reviews] review granted: [Bug 79935] REGRESSION: <content> element is not HTMLUnknownElement when Shadow DOM API is disabled : [Attachment 130339] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Hajime Morrita
<morrita at google.com>'s request for review:
Bug 79935: REGRESSION: <content> element is not HTMLUnknownElement when Shadow
DOM API is disabled
https://bugs.webkit.org/show_bug.cgi?id=79935

Attachment 130339: Patch
https://bugs.webkit.org/attachment.cgi?id=130339&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130339&action=review


This looks fine.  make_names.pl is something of a disaster file, but I haven't
worked up the steam to clean it up yet.

>> Source/WebCore/html/HTMLTagNames.in:97
>> +shadow interfaceName=HTMLShadowElement, conditional=SHADOW_DOM,
runtimeFeature=shadowDOM
> 
> Adam already added runtimeConditional flag in
http://trac.webkit.org/changeset/106603, so let's use that instead.

Yeah, I think runtimeConditional is a slightly better name.