[webkit-reviews] review denied: [Bug 37835] getComputedStyle returns incorrect values for the width and height of pseudo-elements : [Attachment 130372] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Alexis Menard (darktears)
<alexis.menard at openbossa.org>'s request for review:
Bug 37835: getComputedStyle returns incorrect values for the width and height
of pseudo-elements
https://bugs.webkit.org/show_bug.cgi?id=37835

Attachment 130372: Patch
https://bugs.webkit.org/attachment.cgi?id=130372&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130372&action=review


This doesn't look right. E.g., I think you would get the wrong value if
width/height is auto or if min/max width changes the size.  We need to get the
right RenderObject and ask it for the right size.

Does this work properly in IE?

> Source/WebCore/ChangeLog:12
> +	   No new tests : Extend the existing one for pseudo-elements.

Nit: It's nice to name the test in the ChangeLog.