[webkit-reviews] review requested: [Bug 12499] External <use> xlink:href references do not work : [Attachment 130393] Proposed second part

[bugzilla-daemon at webkit.org]

Renata Hodovan <reni at webkit.org> has asked  for review:
Bug 12499: External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499

Attachment 130393: Proposed second part
https://bugs.webkit.org/attachment.cgi?id=130393&action=review

------- Additional Comments from Renata Hodovan <reni at webkit.org>
> Discussed some things with reni on IRC, for the record:
> 
> > Source/WebCore/svg/SVGUseElement.cpp:163
> > +		 if (isExternalURIReference(href())) {
> 
> Oh, just noticing that this is in parseAttribute, not in svgAttributeChanged.

> You won't react properly to SVG DOM changes like
myUseElement.href.baseVal.value = "some-external-reference"; it only works
through setAttribute() using this way.
> Move it into svgAttributeChanged, and it should work - please add a testcase
covering this.
This and the other fixes are done. The old dyn-up tests are also updated to
produce nicer expected pngs.