[webkit-reviews] review denied: [Bug 80412] Web Inspector: extract source mapping logic from DebuggerPresentationModel to ScriptMappingImpl. : [Attachment 130365] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 80412: Web Inspector: extract source mapping logic from
DebuggerPresentationModel to ScriptMappingImpl.
https://bugs.webkit.org/show_bug.cgi?id=80412

Attachment 130365: Patch
https://bugs.webkit.org/attachment.cgi?id=130365&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130365&action=review


> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:-33
> - * @extends {WebInspector.ScriptMapping}

Let's keep ScriptMapping interface implemented by DebuggerPresentationModel to
be used by external clients (uiLocationToRawLocation(),
rawLocationToUILocation() etc.). Beside that we can have a MutableScriptMapping
interface with addScript() and reset() methods to be implemented by
MainScriptMapping and other helper script mappings inside MainScriptMapping.