[webkit-reviews] review granted: [Bug 74279] [GTK] fullscreen/full-screen-iframe-legacy.html is flaky : [Attachment 118759] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 6 07:24:40 PST 2012


Eric Carlson <eric.carlson at apple.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 74279: [GTK] fullscreen/full-screen-iframe-legacy.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=74279

Attachment 118759: Patch
https://bugs.webkit.org/attachment.cgi?id=118759&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=118759&action=review


> LayoutTests/ChangeLog:8
> +	   * fullscreen/full-screen-iframe-legacy.html: Wait canplaythrough

Nit: "Wait for canplaythrough"

> LayoutTests/fullscreen/full-screen-iframe-legacy.html:31
> +    video.load();

This should be unnecessary, setting 'src' triggers a load automatically.


More information about the webkit-reviews mailing list