[webkit-reviews] review denied: [Bug 77437] freetype port: font fallback mechanism can try harder : [Attachment 126260] Allow fontconfig to choose an appropriate font if all else fails

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Martin Jackson
<mjackson220.list at gmail.com>'s request for review:
Bug 77437: freetype port: font fallback mechanism can try harder
https://bugs.webkit.org/show_bug.cgi?id=77437

Attachment 126260: Allow fontconfig to choose an appropriate font if all else
fails
https://bugs.webkit.org/attachment.cgi?id=126260&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=126260&action=review


Looks good, but I think a slightly different design may be in order here.

> Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp:115
> +    const FontFamily* family = &fontDescription.family();
> +    if (family->family().length())
> +	   result = getCachedFontData(fontDescription, family->family(), false,
Retain);
> +

Instead of adding the idea of an in-exact match to the platform-independent
code, I think it's better to first ask Fontconfig what the proper fallback font
is and then get that font explicitly from the font cache.