[webkit-reviews] review granted: [Bug 80413] Add SVGRenderingContext and move there the context related code from SVGRenderSupport : [Attachment 130368] patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 80413: Add SVGRenderingContext and move there the context related code from
SVGRenderSupport
https://bugs.webkit.org/show_bug.cgi?id=80413

Attachment 130368: patch
https://bugs.webkit.org/attachment.cgi?id=130368&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130368&action=review


Looks great! r=me, assuming no regressions.

> Source/WebCore/rendering/svg/SVGRenderingContext.h:38
> +#if ENABLE(FILTERS)

No need to guard class forwards IIRC.

> Source/WebCore/rendering/svg/SVGRenderingContext.h:75
> +    bool isRenderingPrepared() { return m_renderingFlags &
RenderingPrepared; }

Could be const.

> Source/WebCore/rendering/svg/SVGRenderingContext.h:79
> +    // we record all successful steps.

No need to wrap lines here, eh?

> Source/WebCore/rendering/svg/SVGRenderingContext.h:91
> +	   | EndOpacityLayer | EndShadowLayer | EndFilterLayer;

Ditto.