[webkit-reviews] review granted: [Bug 77088] [GStreamer] disable GStreamerGWorld when building against 0.11 : [Attachment 130331] disable GStreamerGWorld when building against 0.11
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 6 06:43:44 PST 2012
Martin Robinson <mrobinson at webkit.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 77088: [GStreamer] disable GStreamerGWorld when building against 0.11
https://bugs.webkit.org/show_bug.cgi?id=77088
Attachment 130331: disable GStreamerGWorld when building against 0.11
https://bugs.webkit.org/attachment.cgi?id=130331&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130331&action=review
> Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.cpp:22
> #include "GStreamerGWorld.h"
> +#ifndef GST_API_VERSION_1
I prefer the compound statement that you use below here. :)
> Source/WebCore/platform/graphics/gstreamer/GStreamerGWorld.h:24
> +#ifndef GST_API_VERSION_1
> #if ENABLE(VIDEO) && USE(GSTREAMER)
Ditto.
More information about the webkit-reviews
mailing list