[webkit-reviews] review granted: [Bug 79678] SVG transform-origin presentation attribute : [Attachment 129716] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted  review:
Bug 79678: SVG transform-origin presentation attribute
https://bugs.webkit.org/show_bug.cgi?id=79678

Attachment 129716: Patch
https://bugs.webkit.org/attachment.cgi?id=129716&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129716&action=review


>>> Source/WebCore/svg/SVGStyledElement.cpp:64
>>> +	 if (!propertyId && attrName == transform_originAttr)
>> 
>> Hm, seems high impact for this special case.
>> Why not change the singe call-site that calls mapAttributetoCSSProperty with
transform_originAttr??
>> Add a new mapWebKitTransformOriginAttrToCSSProperty(..) method.
>> 
>> Also are you sure we want to add this unprefixed for SVG? Is there agreement
that a transform-origin pres attr should exist? Where is it specified?
> 
> I'd like to mention that the map gets filled once during the whole runtime!
The code will just stay as long as 'transform-origin' is prefixed (which won't
be long). So adding new functions might be a bit heavy. What do you think?

Good point, I think its fine as-is!