[webkit-reviews] review requested: [Bug 79795] Unreleased gst_object_reference to audio sink in MediaPlayerPrivateGStreamer : [Attachment 130357] New patch using GRefPtr<GstElement>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 6 04:49:31 PST 2012


David Corvoysier <david.corvoysier at orange.com> has asked  for review:
Bug 79795: Unreleased gst_object_reference to audio sink in
MediaPlayerPrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=79795

Attachment 130357: New patch using GRefPtr<GstElement>
https://bugs.webkit.org/attachment.cgi?id=130357&action=review

------- Additional Comments from David Corvoysier <david.corvoysier at orange.com>
Bug fix: Used a GRefPtr to hold the reference to the audio sink instead of a
GstElement*.
Code cleanup: Used the same pattern for webkit web source and removed explicit
gst_unref in destructor.

Tested it on a typical video page, with GST_DEBUG=GST_REFCOUNTING:5, and
verified both audio sink and webkit web source are properly released.


More information about the webkit-reviews mailing list