[webkit-reviews] review requested: [Bug 9223] Resize handles should be on the lower left corner for rtl : [Attachment 130351] A quick fix v2 (fixed the layout test)

[bugzilla-daemon at webkit.org]

Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 9223: Resize handles should be on the lower left corner for rtl
https://bugs.webkit.org/show_bug.cgi?id=9223

Attachment 130351: A quick fix v2 (fixed the layout test)
https://bugs.webkit.org/attachment.cgi?id=130351&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings Tony,

Thanks for your review and comment.
Sorry, this test failure is totally my fault. The previous test does not work
well on Chromium DumpRenderTree due to a variable-name conflict: this uses a
variable 'top', which causes a conflict with 'window.top'. (I have tested my
previous test only on Safari DumpRenderTree with WTF_USE_RTL_SCROLLBAR
enabled.) I have updated the layout test. (It should work well with Chromium
DumpRenderTree.)

Regards,

Hironori Bono

(In reply to comment #23)
> (From update of attachment 130086 [details])
> This seems fine.  Is the test failing because RTL_SCROLLBAR isn't defined? 
Please fix the test before landing.
> 
> Aharon makes a lot of good points in comment #20, but we should file a new
bug for those issues.