[webkit-reviews] review requested: [Bug 12499] External <use> xlink:href references do not work : [Attachment 130341] Proposed second part

[bugzilla-daemon at webkit.org]

Renata Hodovan <reni at webkit.org> has asked  for review:
Bug 12499: External <use> xlink:href references do not work
https://bugs.webkit.org/show_bug.cgi?id=12499

Attachment 130341: Proposed second part
https://bugs.webkit.org/attachment.cgi?id=130341&action=review

------- Additional Comments from Renata Hodovan <reni at webkit.org>
I'm not pretty sure I understood everything correctly what you asked, but here
is what i thought...

> Also if the <use> element itself gets removed from the tree
(removedFromDocument) shouldn't we release the document?
> I'm thinking of a <use> element which loads a slooow external resource (say
over 1mb large). Now if we remove the <use> from the document, while the
external document is still loading, we could abort the load, and release
m_cachedDocument, no?
This is an ambiguous part for me. If i remove the cachedDocument here, then it
broke the dynamic update by changing from external to internal. So I missed
this part. The others are fulfilled.