[webkit-reviews] review granted: [Bug 78575] Web Inspector: Disable dock button when not allowed to dock : [Attachment 130308] [PATCH] Revised Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 78575: Web Inspector: Disable dock button when not allowed to dock
https://bugs.webkit.org/show_bug.cgi?id=78575

Attachment 130308: [PATCH] Revised Patch
https://bugs.webkit.org/attachment.cgi?id=130308&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130308&action=review


One small comment, otherwise looks good. Thanks for following up.

> Source/WebCore/inspector/InspectorFrontendClient.h:69
> +    virtual void setDockingUnavailable(bool) { }

I think all the ports that are going to call this methods inherit from
InspectorFrontendClientLocal, so you actually don't need it here. It also does
not have to be virtual, it is just a helper function.