[webkit-reviews] review granted: [Bug 80395] Web Inspector: remove reference to RawSourceCode from UISourceCode. : [Attachment 130325] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 80395: Web Inspector: remove reference to RawSourceCode from UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=80395

Attachment 130325: Patch
https://bugs.webkit.org/attachment.cgi?id=130325&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=130325&action=review


> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:217
> +	   for (var i = 0; i < addedItems.length; ++i)

We should probably process removedItems first and then addedItems.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:274
> +	   var script =
WebInspector.debuggerModel.scriptForSourceID(rawLocation.scriptId);

Do you need script at all? Looks like scriptId is enough.