[webkit-reviews] review granted: [Bug 78326] Do not reformat strings in <input type=number> on platforms using LocalizedNumberICU : [Attachment 130287] Patch 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 6 00:50:36 PST 2012


Hajime Morrita <morrita at google.com> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 78326: Do not reformat strings in <input type=number> on platforms using
LocalizedNumberICU
https://bugs.webkit.org/show_bug.cgi?id=78326

Attachment 130287: Patch 4
https://bugs.webkit.org/attachment.cgi?id=130287&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=130287&action=review


ok.

> Source/WebCore/platform/text/LocalizedNumberICU.cpp:142
> +template <class StringType> bool matches(const String& text, unsigned
position, const StringType& part)

Can be static or ALWAYS_INLINE to save namespace pollution?


More information about the webkit-reviews mailing list