[webkit-reviews] review granted: [Bug 68238] [soup] Crash while loading http://www.jusco.cn : [Attachment 130289] Patch fixing segfault

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 68238: [soup] Crash while loading http://www.jusco.cn
https://bugs.webkit.org/show_bug.cgi?id=68238

Attachment 130289: Patch fixing segfault
https://bugs.webkit.org/attachment.cgi?id=130289&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=130289&action=review


Thanks! Just a little nit:

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:683
> +	       handle->setClient(0); // Unset the client so that we do not try
to access th
> +				     // client in the closeCallback.

Maybe the comment can fit in the line above the setClient call? Just a
suggestion to avoid repeating "the client":

// Unset the client so that we do not try to access it in the closeCallback.